Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix acessibility in content module links and timed exams #49

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

sandroscosta
Copy link
Contributor

@sandroscosta sandroscosta commented Jun 26, 2024

This PR solves some issues with the link styles on the module. The link color was not sufficient for color blind users.
As for timed exams, the start button was incorrectly formated.

image

The two issues were fixed:

  • Place a text underline on links that are created in the content area.
  • Fix the styling of the start button on timed exams.

The timed exam start button is now displayed correctly:
image

Related with fccn/edx-platform#16
#46

Place a text underline on links that are created in the content area.
Fix the styling of the start button on timed exams.
@sandroscosta sandroscosta self-assigned this Jun 26, 2024
@igobranco
Copy link
Member

Related to this change: Place a text underline on links that are created in the content area
Before:
image

After:
image

Copy link
Member

@igobranco igobranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't validate the timed exams, but I believe that it should be fixed.

LGTM ✔️

@igobranco igobranco merged commit 8d5ae2a into nau/nutmeg.master Jun 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants